Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugged: Infinite scrolling + Pinned columns (simple fix) #395

Closed
scotthovestadt opened this issue Aug 25, 2015 · 6 comments
Closed

Bugged: Infinite scrolling + Pinned columns (simple fix) #395

scotthovestadt opened this issue Aug 25, 2015 · 6 comments

Comments

@scotthovestadt
Copy link
Contributor

@scotthovestadt scotthovestadt commented Aug 25, 2015

If you use infinite scrolling and pinned columns together, you can scroll on the pinned columns with the mousewheel. The scroll destroys the view.

It looks to be caused because the element borderLayout_eGridPanel has overflow set to "auto". Removing that fixes the issue. I think this is probably a simple fix, but I'm not entirely sure why it's EVER set to auto, so I thought I'd send you the information and you could apply the simple fix in a way that wouldn't break other things.

Screenshots:

With overflow auto (default)
screen shot 2015-08-25 at 3 28 27 pm

Without overflow auto
screen shot 2015-08-25 at 3 28 14 pm

@ceolter

This comment has been minimized.

Copy link
Contributor

@ceolter ceolter commented Aug 26, 2015

@scotthovestadt i can't reproduce. how do you scroll over the pinned columns? scrolling while over the pinned columns i understood to be something you could not do.

@scotthovestadt

This comment has been minimized.

Copy link
Contributor Author

@scotthovestadt scotthovestadt commented Aug 26, 2015

Infinite scrolling + Datasource + Mac trackpad scrolling

The fix is definitely not setting overflow auto on that specific element

@scotthovestadt

This comment has been minimized.

Copy link
Contributor Author

@scotthovestadt scotthovestadt commented Aug 26, 2015

@ceolter My pull request for #398 fixes this bug! Thanks for your time in reviewing.

@ceolter

This comment has been minimized.

Copy link
Contributor

@ceolter ceolter commented Aug 26, 2015

@scotthovestadt will take a look soon. thanks for PR.

@scotthovestadt

This comment has been minimized.

Copy link
Contributor Author

@scotthovestadt scotthovestadt commented Aug 26, 2015

@ceolter Thanks! It will help me a lot if you can merge it in and do a release soon! 👍

I've been using it locally with almost no issues. I made another small commit to handle the one issue I found.

@ceolter

This comment has been minimized.

Copy link
Contributor

@ceolter ceolter commented Jan 17, 2017

this is now fixed i believe.

@ceolter ceolter closed this Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.