Skip to content

Refactor workflow agent api#192

Merged
davorrunje merged 12 commits into
mainfrom
refactor-workflow-agent-api
Sep 13, 2024
Merged

Refactor workflow agent api#192
davorrunje merged 12 commits into
mainfrom
refactor-workflow-agent-api

Conversation

@kumaranvpl
Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes #191

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-anaylysis.sh
  • I have included code examples to illustrate the modifications

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2024

Comment thread fastagency/base.py Outdated
Workflow = TypeVar("Workflow", bound=Callable[["Workflows", UI, str, str], str])


agent_typevar = TypeVar("agent_typevar")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent

)
from ...logging import get_logger

if TYPE_CHECKING:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for conditional

@davorrunje davorrunje added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 05ce5cf Sep 13, 2024
@davorrunje davorrunje deleted the refactor-workflow-agent-api branch September 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Refactor API usage

2 participants