Add tooltip to fields#233
Merged
harishmohanraj merged 4 commits intoSep 17, 2024
Merged
Conversation
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
davorrunje
reviewed
Sep 17, 2024
| str, | ||
| Field( | ||
| description="The system message of the agent. This message is used to inform the agent about his role in the conversation" | ||
| description="The system message of the agent. This message is used to inform the agent about his role in the conversation", |
Contributor
There was a problem hiding this comment.
This is not very elegant. Why don't you create a subclass of Field that has an additional tooltip parameter in its constructor:
import pydantic
class Field(pydantic.Field):
__init__(self, default: Any, *, description: str, tooltip: str, **kwargs: Any):
super():__init__(
default,
description=description,
json_schema_extra={
"metadata": {
"tooltip_message": tooltip
}
}
)Then you can write something like this:
system_message: Annotated[
str,
Field(
description="whatever",
tooltip="whocares",
)
)
davorinrusevljan
previously approved these changes
Sep 17, 2024
davorinrusevljan
approved these changes
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.
Fixes # (issue number)
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-anaylysis.sh