Skip to content

307 add username and password logic to oauth security settings#328

Merged
davorrunje merged 7 commits intomainfrom
307-add-username-and-password-logic-to-oauth-security-settings
Oct 8, 2024
Merged

307 add username and password logic to oauth security settings#328
davorrunje merged 7 commits intomainfrom
307-add-username-and-password-logic-to-oauth-security-settings

Conversation

@sternakt
Copy link
Copy Markdown
Contributor

@sternakt sternakt commented Oct 7, 2024 •
edited
Loading

Description

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

@sternakt sternakt linked an issue Oct 7, 2024 that may be closed by this pull request
Add username and password logic to OAuth security settings #307
Closed
@sternakt sternakt marked this pull request as ready for review October 7, 2024 09:29
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fastagency/api/openapi/security.py 92.00% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
fastagency/api/openapi/security_schema_visitor.py 100.00% <100.00%> (+20.00%) ⬆️
fastagency/api/openapi/security.py 85.04% <92.00%> (+0.77%) ⬆️

@sternakt sternakt requested a review from davorrunje October 7, 2024 09:48
davorrunje
davorrunje suggested changes Oct 7, 2024
View reviewed changes
Comment thread fastagency/api/openapi/security.py Outdated
Comment thread fastagency/api/openapi/security.py Outdated
Comment thread pyproject.toml Outdated
Comment thread tests/api/openapi/security/expected_main_gen.txt Outdated
@davorrunje davorrunje added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit cccb21b Oct 8, 2024
@davorrunje davorrunje deleted the 307-add-username-and-password-logic-to-oauth-security-settings branch October 8, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@davorrunje davorrunje davorrunje approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add username and password logic to OAuth security settings

2 participants

@sternakt @davorrunje