Skip to content

Move pydantic message classes to separate file - #392

Merged
kumaranvpl merged 3 commits into
mainfrom
move-message-class
Oct 15, 2024
Merged

kumaranvpl merged 3 commits into
mainfrom
move-message-class

Conversation

@kumaranvpl

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

@kumaranvpl
kumaranvpl requested a review from davorrunje October 15, 2024 06:52
@codecov

codecov Bot commented Oct 15, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
fastagency/adapters/fastapi/base.py 39.25% <ø> (ø)
fastagency/adapters/nats/base.py 18.88% <ø> (-3.87%) ⬇️
fastagency/messages.py 82.78% <100.00%> (-1.73%) ⬇️

... and 4 files with indirect coverage changes

@kumaranvpl
kumaranvpl added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 8e45cc5 Oct 15, 2024
@kumaranvpl
kumaranvpl deleted the move-message-class branch October 15, 2024 07:36

This branch was previously deployed

1 inactive deployment
testing — d9bfc182 Deployed Oct 15, 2024 by kumaranvpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move NATS pydantic message classes to messages.py

2 participants