Skip to content

Fix parsing of Infobip whatsapp API schema - #516

Merged
davorrunje merged 20 commits into
mainfrom
fix-discriminator-issue
Nov 5, 2024
Merged

Fix parsing of Infobip whatsapp API schema#516
davorrunje merged 20 commits into
mainfrom
fix-discriminator-issue

Conversation

@sternakt

@sternakt sternakt commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes #511
Fixes #446

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • This change requires a documentation update

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

@sternakt sternakt changed the title Fix discriminator issue Fix parsing of Infobip whatsapp API schema Oct 31, 2024
@codecov

codecov Bot commented Oct 31, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 83.67347% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ency/api/openapi/patch_datamodel_code_generator.py 83.33% 4 Missing and 4 partials ⚠️
Files with missing lines Coverage Δ
docs/docs_src/tutorials/whatsapp/main.py 47.82% <100.00%> (ø)
fastagency/api/openapi/client.py 85.33% <ø> (ø)
...ency/api/openapi/patch_datamodel_code_generator.py 83.33% <83.33%> (ø)

... and 7 files with indirect coverage changes

Comment thread docs/docs_src/tutorials/whatsapp/main.py
Comment thread fastagency/api/openapi/__init__.py Outdated
Comment thread tests/api/openapi/templates/test_fastapi_codegen_template.py
@davorrunje
davorrunje added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 757da83 Nov 5, 2024
@davorrunje
davorrunje deleted the fix-discriminator-issue branch November 5, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figure out whatsapp specification issue Correctly parse Infobip OpenAPI spec

3 participants