Skip to content

Use PYPI_API_TOKEN for pypi releases#662

Merged
davorrunje merged 2 commits into
mainfrom
use-pypi-token
Apr 1, 2025
Merged

Use PYPI_API_TOKEN for pypi releases#662
davorrunje merged 2 commits into
mainfrom
use-pypi-token

Conversation

@kumaranvpl
Copy link
Copy Markdown
Contributor

Description

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

@kumaranvpl kumaranvpl requested review from Copilot and davorrunje April 1, 2025 15:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Action for PyPI releases to use the PYPI_API_TOKEN secret as the publishing password.

  • Removed the environment and permissions configuration for trusted publishing.
  • Added the PYPI_API_TOKEN secret for the pypa/gh-action-pypi-publish step.
Comments suppressed due to low confidence (1)

.github/workflows/release_pypi.yaml:12

  • The removal of the 'id-token: write' permission could potentially affect trusted publishing if this permission is required by the pypa/gh-action-pypi-publish action. Please verify that the action does not depend on this permission.
-      id-token: write

@davorrunje davorrunje added this pull request to the merge queue Apr 1, 2025
Merged via the queue into main with commit 7eaf086 Apr 1, 2025
@davorrunje davorrunje deleted the use-pypi-token branch April 1, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants