ci: add zizmor and implement related fixes#2398
Merged
Merged
Conversation
Contributor
Author
|
A couple things I've noticed after having CI run here:
|
sobolevn
reviewed
Jul 31, 2025
`zizmor` flags this as a potential "cache poisoning" vulnerability. More at https://codeql.github.com/codeql-query-help/actions/actions-cache-poisoning-direct-cache/
`zizmor` flags all actions not pinned to a hash. I used gha-update (https://gha-update.readthedocs.io/en/latest/) to automatically pin all to the latest version.
This resolves several `zizmor` flags.
This resolves a lot of `zizmor` flags.
This failed when running on my fork—reverting my change and adding an ignore for the `zizmor` warning I tried to fix.
Lancetnik
approved these changes
Aug 4, 2025
Lancetnik
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
zizmor, a static analysis tool for GitHub Actions.zizmoras a lint dependencyjust zizmorcommandjust zizmorwhen editing workflow files (this also addszizmorto GitHub Actions since pre-commit is run on all pushes/PRs)I also resolved all existing
zizmormessages, either by implementing a fix or by ignoring the specific flag in a new.github/zizmor.ymlfile:cf7aa43dc0026951952b6ae45609ef4539223f05rather thanv1ormaster)zizmorflagged as a potential cache poisoning vulnerabilitypull_request_targettrigger instead ofpull_requestFixes #2397
Type of change
CI and developer tooling improvements.
Checklist
scripts/lint.shshows no errors)scripts/test-cov.shscripts/static-analysis.sh