From edff7fdcf997937456a9166572f20966cef0f25f Mon Sep 17 00:00:00 2001 From: Agata Stawarz-Pastewska Date: Mon, 7 Dec 2020 16:09:57 +0100 Subject: [PATCH] Fix types --- .../components/nativeFilters/FilterBar.tsx | 22 ++++++++++++++----- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx index 48112e39be5e..c766c56a04f3 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx @@ -16,7 +16,13 @@ * specific language governing permissions and limitations * under the License. */ -import { QueryFormData, styled, SuperChart, t } from '@superset-ui/core'; +import { + QueryFormData, + styled, + SuperChart, + t, + ExtraFormData, +} from '@superset-ui/core'; import React, { useState, useEffect } from 'react'; import { useSelector } from 'react-redux'; import cx from 'classnames'; @@ -145,7 +151,7 @@ const FilterControls = styled.div` interface FilterProps { filter: Filter; - onExtraFormDataChange: any; + onExtraFormDataChange: (filter: Filter, extraFormData: ExtraFormData) => void; } interface FiltersBarProps { @@ -198,7 +204,7 @@ const FilterValue: React.FC = ({ } }, [cascadingFilters]); - const setExtraFormData = (extraFormData: any) => + const setExtraFormData = (extraFormData: ExtraFormData) => onExtraFormDataChange(filter, extraFormData); return ( @@ -241,8 +247,9 @@ const FilterBar: React.FC = ({ filtersOpen, toggleFiltersBar, }) => { - const [filterData, setFilterData] = useState({}); - + const [filterData, setFilterData] = useState<{ [id: string]: ExtraFormData }>( + {}, + ); const setExtraFormData = useSetExtraFormData(); const filterConfigs = useFilterConfiguration(); const canEdit = useSelector( @@ -255,7 +262,10 @@ const FilterBar: React.FC = ({ } }, [filterConfigs]); - const handleExtraFormDataChange = (filter: Filter, extraFormData: any) => { + const handleExtraFormDataChange = ( + filter: Filter, + extraFormData: ExtraFormData, + ) => { setFilterData(prevFilterData => ({ ...prevFilterData, [filter.id]: extraFormData,