Upstream changes #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under "Events", the export to view all event types was mislabeled as `TrackPlayerEventTypes` Changed documentation to match correct name of `TrackPlayerEvents`. See: https://github.com/react-native-kit/react-native-track-player/blob/97692c6894c5ffaae9ad5772c4db0e24c420ac0d/lib/index.js#L202-L203
…xception: invalid channel for service notification: null (#723)
* Call `playback-track-changed` for penultimate track too * Fix duplicate `playback-track-changed` call * Fixed code style, reduced condition checking
…control specific timing of queue events. Still advances to the next track without further JS code. (#822)
(cherry picked from commit 99f8524)
(cherry picked from commit 3f26e6a)
(cherry picked from commit 170c14a)
|
@lukebaker It looks like I don't have write access to this repo, any chance you can take a look at this? Thanks! |
|
@jeffmon I've given you write access. Do you still want me to take a look at this? |
|
@lukebaker Thanks for that! Would it be wise to merge in all of the things from their |
Open
|
Seem my changes in #4. I think that does what we want. |
* fix: Remove iOS SwiftAudio unnecessary files * Remove extra line * Update .npmignore * Podspect exclude files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.