Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream agathon #4

Open
wants to merge 35 commits into
base: agathon
Choose a base branch
from
Open

Upstream agathon #4

wants to merge 35 commits into from

Conversation

lukebaker
Copy link

No description provided.

dcvz and others added 30 commits July 6, 2019 11:12
@dcvz
Modernize package structure (doublesymmetry#654)
aca34d7
@dcvz
[ios] Update base player
99f8524
@dcvz
[ios] Update podspec for RN 0.60
1607df4
@dcvz
[iOS] Fix issue conforming to protocol
3f26e6a
@dcvz
Improve hook for getting progress
5daf491 
BREAKING CHANGE: name update and properties
@dcvz
Rename bufferedPosition to buffered in progress hook
434baf7
@dcvz
Export `useProgress hook
53b765f
@dcvz
[ios] Fix setting of remoteCommands
56961c3
@jonnyberanek @Guichaguri
[docs] Fixed misnamed export typo in Documentation.md (doublesymmetry…
1a6a627 
…#756)

Under "Events", the export to view all event types was mislabeled as `TrackPlayerEventTypes`

Changed documentation to match correct name of `TrackPlayerEvents`. See: https://github.com/react-native-kit/react-native-track-player/blob/97692c6894c5ffaae9ad5772c4db0e24c420ac0d/lib/index.js#L202-L203
@Guichaguri
[android] Updated androidx libraries
9b60f3f
@biomancer @Guichaguri
[androidFix: Bad notification for startForeground: java.lang.RuntimeE…
00ffdcc 
…xception: invalid channel for service notification: null (doublesymmetry#723)
@skahack @Guichaguri
[android] Fixed array index out of bounds crash (doublesymmetry#778)
ecf98fb 
Closes doublesymmetry#778
@high-performance-hery @Guichaguri
[iOSCall playback-track-changed for last track (doublesymmetry#772)
1c3fefc 
* Call `playback-track-changed` for penultimate track too

* Fix duplicate `playback-track-changed` call

* Fixed code style, reduced condition checking
@Guichaguri
Fixed noisy receiver not being disposed after stopping the player
a53707d
@Guichaguri
Remove now useless configuration files
5771543
@Guichaguri
[android] Prevents unbound calls to destroy
bf4cfb8
@Guichaguri
[docs] Make the getDuration() note a bit clearer
2158450
@Guichaguri
Merge branch 'dev' into v2
5a5c709
@dcvz @Guichaguri
Split Metadata Functionality (doublesymmetry#634)
d0f782f 
Let's allow the user to update the metadata for an upcoming track (similar to how we already do), that we let them update the data that we're currently showing (doesn't have to be tied to the tracks) and we allow them to clear it.

This way we give users flexibility and control. Therefore satisfying a lot more needs.
@Guichaguri
[docs] Added cleartext HTTP to the troubleshooting section
706585d
@ovr @Guichaguri
Fix(d.ts): Track - add headers field (doublesymmetry#824)
27517c9
@curiousdustin @Guichaguri
[ios] Disable automaticallyPlayNextSong in SwiftAudio so that we can …
c34d240 
…control specific timing of queue events. Still advances to the next track without further JS code. (doublesymmetry#822)
@Guichaguri
Merge branch 'dev' into v2
a92588e
@Guichaguri
[android] Updated androidx core
85e2898
@Guichaguri
[android] Fix the last known window after removing a track
8698cff
@Guichaguri
[iOS] Updated SwiftAudio submodule
170c14a
@dcvz @Guichaguri
[ios] Update base player
2b76ef7 
(cherry picked from commit 99f8524)
@dcvz @Guichaguri
[iOS] Fix issue conforming to protocol
e270f7d 
(cherry picked from commit 3f26e6a)
@Guichaguri
[iOS] Updated SwiftAudio submodule
e76f25e 
(cherry picked from commit 170c14a)
@Guichaguri
Merge branch 'dev' into v2
e2cf596
@lukebaker
Copy link
Author

lukebaker commented Jan 14, 2020 •
edited

@jeffmon in #3, I merged the upstream changes into our dev branch which is nearly identical[1] to dev of the primary repository. However, our agathon branches has several changes. It has our modifications and there's git sub-module in the primary repo that I've copied and put in place in the agathon branch, so that we can use it from yarn. This pull request merges the changes from dev and updates our local copy of that git sub-module to match the commit that dev is pulling in.

Feel free to test this via updating package.json to temporarily use this upstream-agathon branch. If it looks good to you, feel free to merge this pull request into agathon.

[1] It has some additional merge commits of these merges, but no content differences.

@lukebaker lukebaker mentioned this pull request Jan 14, 2020
Closed
@jeffmon
Copy link
Member

jeffmon commented Jan 14, 2020

@lukebaker Thanks for doing this! I'll test upstream-agathon extensively on multiple devices.

@jeffmon
Merge branch 'v2' of https://github.com/react-native-kit/react-native…
93c474b 
…-track-player into upstream-agathon

* 'v2' of https://github.com/react-native-kit/react-native-track-player:
  [iOS] Updated SwiftAudio submodule
  [android] Updated androidx core
  Fix(d.ts): Track - add headers field (doublesymmetry#824)
  Split Metadata Functionality (doublesymmetry#634)
  [ios] Fix setting of `remoteCommands`
  Export `useProgress hook
  Rename `bufferedPosition` to `buffered` in progress hook
  Improve hook for getting progress
  [iOS] Fix issue conforming to protocol
  [ios] Update podspec for RN 0.60
  [ios] Update base player
  Modernize package structure (doublesymmetry#654)
@jeffmon
Fix remote controls on iOS
1d6af19
@jeffmon
Revert "Merge branch 'v2' of https://github.com/react-native-kit/reac…
8627fd2 
…t-native-track-player into upstream-agathon"

This reverts commit 93c474b, reversing
changes made to c5353c6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jeffmon jeffmon

Labels
None yet
Projects
None yet
Milestone
No milestone
10 participants
@lukebaker @jeffmon @dcvz @jonnyberanek @Guichaguri @biomancer @skahack @high-performance-hery @ovr @curiousdustin