Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream agathon #4

Open
wants to merge 35 commits into
base: agathon
Choose a base branch
from
Open

Upstream agathon #4

wants to merge 35 commits into from

Conversation

lukebaker
Copy link

No description provided.

dcvz and others added 30 commits July 6, 2019 11:12
BREAKING CHANGE: name update and properties
…#756)

Under "Events", the export to view all event types was mislabeled as `TrackPlayerEventTypes`

Changed documentation to match correct name of `TrackPlayerEvents`. See: https://github.com/react-native-kit/react-native-track-player/blob/97692c6894c5ffaae9ad5772c4db0e24c420ac0d/lib/index.js#L202-L203
…xception: invalid channel for service notification: null (doublesymmetry#723)
* Call `playback-track-changed` for penultimate track too

* Fix duplicate `playback-track-changed` call

* Fixed code style, reduced condition checking
Let's allow the user to update the metadata for an upcoming track (similar to how we already do), that we let them update the data that we're currently showing (doesn't have to be tied to the tracks) and we allow them to clear it.

This way we give users flexibility and control. Therefore satisfying a lot more needs.
…control specific timing of queue events. Still advances to the next track without further JS code. (doublesymmetry#822)
(cherry picked from commit 99f8524)
(cherry picked from commit 170c14a)
@lukebaker
Copy link
Author

lukebaker commented Jan 14, 2020

@jeffmon in #3, I merged the upstream changes into our dev branch which is nearly identical[1] to dev of the primary repository. However, our agathon branches has several changes. It has our modifications and there's git sub-module in the primary repo that I've copied and put in place in the agathon branch, so that we can use it from yarn. This pull request merges the changes from dev and updates our local copy of that git sub-module to match the commit that dev is pulling in.

Feel free to test this via updating package.json to temporarily use this upstream-agathon branch. If it looks good to you, feel free to merge this pull request into agathon.

[1] It has some additional merge commits of these merges, but no content differences.

@jeffmon
Copy link
Member

jeffmon commented Jan 14, 2020

@lukebaker Thanks for doing this! I'll test upstream-agathon extensively on multiple devices.

…-track-player into upstream-agathon

* 'v2' of https://github.com/react-native-kit/react-native-track-player:
  [iOS] Updated SwiftAudio submodule
  [android] Updated androidx core
  Fix(d.ts): Track - add headers field (doublesymmetry#824)
  Split Metadata Functionality (doublesymmetry#634)
  [ios] Fix setting of `remoteCommands`
  Export `useProgress hook
  Rename `bufferedPosition` to `buffered` in progress hook
  Improve hook for getting progress
  [iOS] Fix issue conforming to protocol
  [ios] Update podspec for RN 0.60
  [ios] Update base player
  Modernize package structure (doublesymmetry#654)
…t-native-track-player into upstream-agathon"

This reverts commit 93c474b, reversing
changes made to c5353c6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants