a couple fixes #1

Merged
merged 5 commits into from Sep 22, 2011

Conversation

Projects
None yet
2 participants
@bmaupin
Contributor

bmaupin commented Aug 22, 2011

assaalamu alaykum

I found some errors with the glyphs for ط and ظ and corrected them. For ط, the final and medial forms were mixed up. For ظ, the final form was listed in place of the medial form.

I also fixed the Java warning that was showing up in the Arabic Utilities class related to referencing a generic type.

shukran

@agawish

This comment has been minimized.

Show comment Hide comment
@agawish

agawish Aug 22, 2011

Owner

Great, thanks

Owner

agawish commented Aug 22, 2011

Great, thanks

bmaupin added some commits Aug 25, 2011

fix bug causing all text to be appended with a space and a line feed …
…character; java has no string.join method, so we have to manually ensure the separator doesn't get appended to the final array item
@bmaupin

This comment has been minimized.

Show comment Hide comment
@bmaupin

bmaupin Sep 2, 2011

Contributor

I found and fixed a few more bugs:

  1. I fixed a bug where the final "word" in mixed words passed to getWordsFromMixedWord() would get dropped.

    for example, this: سَكَنُ (الطُلاّبِ)‏
    would return this: سَكَنُ (الطُلاّبِ‏

    and this: تَفَضَّلْ/تَفَضَّلي‏
    would return this: تَفَضَّلْ/‏

    lastly, this: آسِف، آسِفة‏
    would return this: آسِف آسِفة‏

  2. I fixed a bug causing all text to be appended with a space and a line feed character

  3. I fixed a glyph for أ (the isolated form was incorrectly using the ﺂ final form glyph)

Please consider merging this pull request.

Thanks.

Contributor

bmaupin commented Sep 2, 2011

I found and fixed a few more bugs:

  1. I fixed a bug where the final "word" in mixed words passed to getWordsFromMixedWord() would get dropped.

    for example, this: سَكَنُ (الطُلاّبِ)‏
    would return this: سَكَنُ (الطُلاّبِ‏

    and this: تَفَضَّلْ/تَفَضَّلي‏
    would return this: تَفَضَّلْ/‏

    lastly, this: آسِف، آسِفة‏
    would return this: آسِف آسِفة‏

  2. I fixed a bug causing all text to be appended with a space and a line feed character

  3. I fixed a glyph for أ (the isolated form was incorrectly using the ﺂ final form glyph)

Please consider merging this pull request.

Thanks.

@agawish agawish closed this Sep 14, 2011

@agawish agawish reopened this Sep 22, 2011

agawish added a commit that referenced this pull request Sep 22, 2011

@agawish agawish merged commit 82b02af into agawish:master Sep 22, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment