Fix tilemap gaps in affine graphic modes #733 #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwilymk
reviewed
Jul 10, 2024
agb/src/display/tiled/map.rs
Outdated
|
|
||
| if *self.tiles_dirty() { | ||
| unsafe { | ||
| let tiledata: Vec<u8> = self.tiles_mut().iter().map(|a| a.tile_index(FourBpp).raw_index() as u8).collect(); |
There was a problem hiding this comment.
Should this be EightBpp? I know that it doesn't actually make a difference, but it feels more correct here :)
Could you also pull this line out of the unsafe block since it doesn't really need to go there
There was a problem hiding this comment.
Pushed it in the latest commit :)
CHANGELOG.md
Outdated
| @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Fixed | |||
| - Kludge fix for tilemap gaps in affine graphics modes. | |||
There was a problem hiding this comment.
Suggested change
| - Kludge fix for tilemap gaps in affine graphics modes. | |
| - There are no longer gaps between tiles in affine graphics modes. |
|
Looks like |
…straight from the underlying type.
|
@gwilymk Pushed some more fixes for the Just CI build :) |
|
Amazing, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue Affine tilemaps show gaps #733 where affine tilemaps have a gap.