Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ refactor ] Stream's iterate #530

Merged
merged 2 commits into from Nov 25, 2018
Merged

[ refactor ] Stream's iterate #530

merged 2 commits into from Nov 25, 2018

Conversation

gallais
Copy link
Member

@gallais gallais commented Nov 12, 2018

  • Instead of stacking map after map on top of each other, we
    use unfold's internal state to carry the updated seed value.

  • Because unfold's argument is of type A → A × A, we could easily
    introduce a bug here so we also prove a correction lemma for the
    refactored version.

* Instead of stacking `map` after `map` on top of each other, we
  use `unfold`'s internal state to carry the updated seed value.

* Because `unfold`'s argument is of type `A → A × A`, we could easily
  introduce a bug here so we also prove a correction lemma for the
  refactored version.
@MatthewDaggitt
Copy link
Contributor

Oooh wow, a use case for GeneralisedArithmetic!

Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@gallais gallais added this to In Progress in codata via automation Nov 13, 2018
@MatthewDaggitt MatthewDaggitt added this to the v0.18 milestone Nov 25, 2018
@MatthewDaggitt MatthewDaggitt merged commit 7fe9441 into master Nov 25, 2018
codata automation moved this from In Progress to Done Nov 25, 2018
@MatthewDaggitt MatthewDaggitt deleted the refactor-iterate branch November 25, 2018 13:38
@MatthewDaggitt MatthewDaggitt modified the milestones: v0.18, v1.0 Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
codata
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants