Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn "missing definition" into a warning #2929

Closed
gallais opened this issue Jan 29, 2018 · 2 comments
Closed

Turn "missing definition" into a warning #2929

gallais opened this issue Jan 29, 2018 · 2 comments
Assignees
@gallais
Labels
scope Issues relating to scope checking type: enhancement Issues and pull requests about possible improvements ux: warnings Issues relating to the reporting of warnings
Milestone
2.6.0

Comments

@gallais
Copy link
Member

gallais commented Jan 29, 2018

If we find a declaration without an accompanying body, we can simply raise a warning,
refuse to make it available in the scope (or do so and declare it "NON_TERMINATING"
to avoid unfolding) but let the user keep interacting with the file.
@gallais gallais added type: enhancement Issues and pull requests about possible improvements scope Issues relating to scope checking ux: warnings Issues relating to the reporting of warnings labels Jan 29, 2018
@gallais gallais self-assigned this Jan 29, 2018
@UlfNorell UlfNorell added this to the 2.5.5 milestone Jun 1, 2018
@m0davis
Copy link

m0davis commented Oct 29, 2018

Isn't this already fixed by #3196?

@gallais
Copy link
Member Author

gallais commented Oct 29, 2018

Indeed it is!

@gallais gallais closed this as completed Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gallais gallais

Labels
scope Issues relating to scope checking type: enhancement Issues and pull requests about possible improvements ux: warnings Issues relating to the reporting of warnings
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
3 participants
@m0davis @UlfNorell @gallais