Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment on catchIlltypedPatternBlockedOnMeta needs update #7045

Open
andreasabel opened this issue Jan 2, 2024 · 1 comment
Open

Comment on catchIlltypedPatternBlockedOnMeta needs update #7045

andreasabel opened this issue Jan 2, 2024 · 1 comment
Assignees
Labels
bit-rot Functionality broken by refactorings etc. type: task Concerning the development of Agda (not in changelog)
Milestone

Comments

@andreasabel
Copy link
Member

@UlfNorell, please have a look at this comment and update it to the current situation:

-- Note that the returned meta might only exists in the state where the error was
-- thrown, thus, be an invalid 'MetaId' in the current state.
--
catchIlltypedPatternBlockedOnMeta :: TCM a -> ((TCErr, Blocker) -> TCM a) -> TCM a

  • There is no more meta returned or passed to the continuation. Instead, there is a Blocker.
  • Does the comment still apply to the blocker?

Raised in 552987a#r136034513.

@andreasabel andreasabel added the bit-rot Functionality broken by refactorings etc. label Jan 2, 2024
@andreasabel andreasabel added this to the 2.6.4.2 milestone Jan 2, 2024
@andreasabel andreasabel added the type: task Concerning the development of Agda (not in changelog) label Apr 17, 2024
@andreasabel andreasabel modified the milestones: 2.6.5, 2.7.0 Apr 17, 2024
@andreasabel
Copy link
Member Author

Doesn't make sense to raise these kind of issues if folks do not take responsibility.

@andreasabel andreasabel modified the milestones: 2.7.0, icebox Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bit-rot Functionality broken by refactorings etc. type: task Concerning the development of Agda (not in changelog)
Projects
None yet
Development

No branches or pull requests

2 participants