Restrict type of equivProof; Remove primIdJ; Rename ouc→outS everywhere#6032
Merged
Conversation
127aa28 to
145dc40
Compare
Co-authored-by: Jon Sterling <jonsterling@users.noreply.github.com>
145dc40 to
0bcba1e
Compare
Contributor
Author
|
Someone should stop me from using DVCS.. "I'm not owned, I'm not owned, I continue to insist as I slowly shrink and turn into an octopus merge." |
Member
|
Looks like you need to update a testcase: https://github.com/agda/agda/runs/7866031500?check_suite_focus=true#step:9:30 |
... didn't I write that test case? Hoist by my own petard
Contributor
Author
|
I'm gonna go ahead and merge this since it's unlikely anyone will weep for |
Member
|
@plt-amy: Thanks for this fix! Would you mind adding this to the CHANGELOG? |
plt-amy
added a commit
that referenced
this pull request
Aug 17, 2022
Member
|
Excellent, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #6012, which I screwed up in my fork. Closes #5661, by ensuring that the fibre returned from equivTransp must be an extension of the given partial fibre: this implies that EQUIVFUN must have contractible fibres.
Closes #3714, by.. well, renaming inc and ouc everywhere.
Removes
primIdJ, which can be recovered as eitherOr as
Updates the docs to mention pattern matching on reflId and to mention that cubical builtins are touchy even when they aren't deep magic.