Skip to content

Clean up cubical primitives - #6034

Merged
plt-amy merged 5 commits into
masterfrom
aliao/cubical-clean-up
Aug 18, 2022
Merged

plt-amy merged 5 commits into
masterfrom
aliao/cubical-clean-up

Conversation

@plt-amy

@plt-amy plt-amy commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

Step one in my evil plan to replace abuses of the interval by a proper cofibration classifier is to clean up all the Cubical Agda primitives. Here's ~60% of them.

@plt-amy plt-amy added type: enhancement Issues and pull requests about possible improvements type: task Concerning the development of Agda (not in changelog) cubical Cubical Agda paraphernalia: Paths, Glue, partial elements, hcomp, transp labels Aug 18, 2022
@plt-amy plt-amy self-assigned this Aug 18, 2022

@andreasabel andreasabel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
As this PR has lots of code movement, I cannot sensibly review the changes.
Where I could, I gave some minor stylistic comments.

Comment thread src/full/Agda/TypeChecking/Conversion.hs Outdated
Comment thread src/full/Agda/Compiler/Common.hs Outdated
Comment thread src/full/Agda/TypeChecking/Primitive/Cubical/Id.hs Outdated
@plt-amy
plt-amy merged commit 503a9bd into master Aug 18, 2022
@plt-amy
plt-amy deleted the aliao/cubical-clean-up branch October 27, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cubical Cubical Agda paraphernalia: Paths, Glue, partial elements, hcomp, transp type: enhancement Issues and pull requests about possible improvements type: task Concerning the development of Agda (not in changelog)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants