Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup tests #487

Merged
merged 1 commit into from Jul 26, 2017
Merged

cleanup tests #487

merged 1 commit into from Jul 26, 2017

Conversation

@OmgImAlexis
Copy link
Member

OmgImAlexis commented Jul 26, 2017

This switches the test requires to using const instead of var and splits the file into three separate files so they're easier to manage.

@OmgImAlexis OmgImAlexis added this to the 1.0.0 milestone Jul 26, 2017
@OmgImAlexis OmgImAlexis changed the title fix require var -> const and split test files cleanup tests Jul 26, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 26, 2017

Coverage Status

Coverage decreased (-9.9%) to 79.966% when pulling e6205e5 on cleanup/split-tests into 955fd0c on master.

@OmgImAlexis

This comment has been minimized.

Copy link
Member Author

OmgImAlexis commented Jul 26, 2017

@simison looks good?

@simison

This comment has been minimized.

Copy link
Member

simison commented Jul 26, 2017

@OmgImAlexis

This comment has been minimized.

Copy link
Member Author

OmgImAlexis commented Jul 26, 2017

Shall I merge or wait for a LGTM from another member?

@lushc

This comment has been minimized.

Copy link
Member

lushc commented Jul 26, 2017

Might as well go all the way and replace the remaining instances of var with let?

@OmgImAlexis

This comment has been minimized.

Copy link
Member Author

OmgImAlexis commented Jul 26, 2017

I was going to do that once this is merged along with more xo changes.

@lushc

This comment has been minimized.

Copy link
Member

lushc commented Jul 26, 2017

Alright cool, LGTM!

@OmgImAlexis OmgImAlexis merged commit 2411cb3 into master Jul 26, 2017
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-9.9%) to 79.966%
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@OmgImAlexis OmgImAlexis deleted the cleanup/split-tests branch Jul 26, 2017
@OmgImAlexis OmgImAlexis modified the milestones: 1.0.0, 0.10.0 Jul 29, 2017
timelf123 added a commit to ideawake/agenda that referenced this pull request Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.