Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only send lib to npm #491

Merged
merged 1 commit into from Jul 28, 2017
Merged

only send lib to npm #491

merged 1 commit into from Jul 28, 2017

Conversation

@OmgImAlexis
Copy link
Member

OmgImAlexis commented Jul 28, 2017

This slims down the package downloaded via npm since we exclude the test directory and files such as .eslintrc and .travis.yml.

Before:

yarn pkgfiles v0.27.5
$ "/Users/xo/code/agenda/node_modules/.bin/pkgfiles"

PATH                              SIZE     %   
.npmignore                        38 B     0%  
index.js                          58 B     0%  
.editorconfig                     360 B    0%  
docker-compose.yml                378 B    0%  
test/fixtures/agenda-instance.js  669 B    0%  
.eslintrc                         896 B    0%  
package.json                      1.07 kB  1%  
LICENSE.md                        1.11 kB  1%  
test/fixtures/addTests.js         1.83 kB  1%  
test/retry.js                     2.26 kB  1%  
History.md                        8.99 kB  5%  
lib/job.js                        11.3 kB  6%  
test/agenda.js                    16.1 kB  8%  
README.md                         27.9 kB  15% 
test/job.js                       31.7 kB  17% 
lib/agenda.js                     36.3 kB  19% 
yarn.lock                         48.8 kB  26% 
                                               
DIR                               SIZE     %   
test/fixtures/                    2.5 kB   1%  
lib/                              47.7 kB  25% 
test/                             52.5 kB  28% 
.                                 190 kB   100%

PKGFILES SUMMARY
Size on Disk with Dependencies  ~42.5 MB
Size with Dependencies          ~30.3 MB
Publishable Size                ~190 kB 
Number of Directories           4       
Number of Files                 17      
Done in 2.57s.

After:

yarn pkgfiles v0.27.5
$ "/Users/xo/code/agenda/node_modules/.bin/pkgfiles"

PATH           SIZE     %   
index.js       58 B     0%  
package.json   1.09 kB  1%  
LICENSE.md     1.11 kB  1%  
History.md     8.99 kB  10% 
lib/job.js     11.3 kB  13% 
README.md      27.9 kB  32% 
lib/agenda.js  36.3 kB  42% 
                            
DIR            SIZE     %   
lib/           47.7 kB  55% 
.              86.8 kB  100%

PKGFILES SUMMARY
Size on Disk with Dependencies  ~42.5 MB
Size with Dependencies          ~30.3 MB
Publishable Size                ~86.8 kB
Number of Directories           2       
Number of Files                 7       
Done in 2.71s.
@OmgImAlexis OmgImAlexis modified the milestone: 1.0.0 Jul 28, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 28, 2017

Coverage Status

Coverage remained the same at 80.034% when pulling b41abea on slimdown-npm into c84c523 on master.

@simison simison self-requested a review Jul 28, 2017
@simison simison added the build tools label Jul 28, 2017
@simison simison modified the milestones: 0.10.0, 1.0.0 Jul 28, 2017
@simison

This comment has been minimized.

Copy link
Member

simison commented Jul 28, 2017

Great! Feel free to merge so that this goodie can go to 0.10.0

LGTM

@OmgImAlexis OmgImAlexis merged commit ad3dbf7 into master Jul 28, 2017
4 checks passed
4 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 80.034%
Details
@OmgImAlexis OmgImAlexis deleted the slimdown-npm branch Jul 28, 2017
timelf123 added a commit to ideawake/agenda that referenced this pull request Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.