New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme header #499

Merged
merged 3 commits into from Aug 8, 2017

Conversation

Projects
None yet
4 participants
@simison
Member

simison commented Aug 8, 2017

Adds logo and makes header all around sexier

@simison simison added the docs label Aug 8, 2017

@simison simison self-assigned this Aug 8, 2017

@OmgImAlexis

This comment has been minimized.

Member

OmgImAlexis commented Aug 8, 2017

Seems to be a tad broken.

screen shot 2017-08-08 at 7 28 27 pm

@simison simison changed the title from Update readme header to [WIP] Update readme header Aug 8, 2017

@simison

This comment has been minimized.

Member

simison commented Aug 8, 2017

@OmgImAlexis yeah sorry, work-in-progress. :-) It's hard to see how it renders on github without PR.

@OmgImAlexis

This comment has been minimized.

Member

OmgImAlexis commented Aug 8, 2017

Use this and hit preview to check.

@simison

This comment has been minimized.

Member

simison commented Aug 8, 2017

Done!

image

Gotta clean out that history.md from this, somehow sneaked it in by squashing.

I'll merge if you agree is good.

@agenda agenda deleted a comment from coveralls Aug 8, 2017

@agenda agenda deleted a comment from coveralls Aug 8, 2017

@coveralls

This comment has been minimized.

coveralls commented Aug 8, 2017

Coverage Status

Coverage decreased (-0.3%) to 80.366% when pulling 1478bab on update-readme-header into bf98c65 on master.

README.md Outdated
It offers:
<p align="center">
<img src="https://cdn.rawgit.com/agenda/agenda/update-readme-header/agenda.svg" alt="Agenda" width="100" height="100">

This comment has been minimized.

@lushc

lushc Aug 8, 2017

Member

Not sure if you were planning on doing this already, but I'd replace update-readme-header with master before merging, just in case this branch ever gets pruned 😅

This comment has been minimized.

@simison

simison Aug 8, 2017

Member

Yep totally, I'll have to replace this with https://cdn.rawgit.com/agenda/agenda/agenda.svg right before merging. Thanks. :-)

@simison

This comment has been minimized.

Member

simison commented Aug 8, 2017

BTW what's going on with Travis?

Lots of random hiccups!

1) Job job concurrency should run jobs as first in first out (FIFO) with respect to priority:
     Error: Timeout of 8000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

@agenda agenda deleted a comment from coveralls Aug 8, 2017

@agenda agenda deleted a comment from coveralls Aug 8, 2017

@agenda agenda deleted a comment from coveralls Aug 8, 2017

simison added some commits Aug 8, 2017

@simison simison changed the title from [WIP] Update readme header to Update readme header Aug 8, 2017

@simison simison merged commit e67e522 into master Aug 8, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codeclimate All good!
Details

@simison simison deleted the update-readme-header branch Aug 8, 2017

@OmgImAlexis

This comment has been minimized.

Member

OmgImAlexis commented Aug 8, 2017

That's expected. Loads of the tests rely on each other for some reason which causes timeouts to happen 50% of the time.

I have a fix for that but we need to switch to avajs first to allow process isolation and I can't do that until the xo PR gets merged.

timelf123 added a commit to ideawake/agenda that referenced this pull request Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment