Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
split lib/*.js into single files #503
I know this is another massive change but this was inevitable. The main file was getting way too large which meant every single time we have more than one person working on a section there's conflicts over the whole file. This fixes that as well as allowing us to setup debug more cleanly by each file having it's own debug field instead of every single function inside of
@simison shall I just merge once the PR goes green? I'm more than happy to rebase any/all PRs that I've broken.
@OmgImAlexis Let's get quick a review for this.
While I really like the sentiment, I'm not sure if every method should have it's own file. I don't really have anything else to suggest tho so I'm giving this
If nobody else replies within ~24h I think we can merge.
Love to see this kind of big refactoring done!
I'm with you on that, the reason I went with all methods is that we might as well and it'll be cleaner seeing unit tests separated for each method.
For example you'd have