Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upsplit lib/*.js into single files #503
Conversation
simison
requested review from
simison,
lushc and
niftylettuce
Aug 12, 2017
This comment has been minimized.
This comment has been minimized.
|
@OmgImAlexis Let's get quick a review for this. While I really like the sentiment, I'm not sure if every method should have it's own file. I don't really have anything else to suggest tho so I'm giving this If nobody else replies within ~24h I think we can merge. Love to see this kind of big refactoring done! |
| super(); | ||
| if (!(this instanceof Agenda)) { | ||
| return new Agenda(config); | ||
| } | ||
| config = config ? config : {}; |
This comment has been minimized.
This comment has been minimized.
| super(); | ||
| if (!(this instanceof Agenda)) { | ||
| return new Agenda(config); | ||
| } | ||
| config = config ? config : {}; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I'm with you on that, the reason I went with all methods is that we might as well and it'll be cleaner seeing unit tests separated for each method. For example you'd have |
This comment has been minimized.
This comment has been minimized.
This was my thinking as well for +1, but maybe there's something I can't think of now to make working on this nice as well. :-) |
This comment has been minimized.
This comment has been minimized.
|
Once we merge this I'm going to switch all tests to avajs and split them up. That should help us get to the bottom of these flaky tests. Off to bed(4:30am here). |
OmgImAlexis
changed the title from
split agenda.js into single files
to
split lib/*.js into single files
Aug 13, 2017
This comment has been minimized.
This comment has been minimized.
|
@simison would you mind reviewing the last commit. |
This comment has been minimized.
This comment has been minimized.
|
LGTM! Now that I think of this again, having everything split into small files will help to write atomic code. Will be exciting to see ava tests in action! Ready for merge? |
simison
assigned
OmgImAlexis
Aug 14, 2017
OmgImAlexis
merged commit 2d78b12
into
master
Aug 14, 2017
OmgImAlexis
deleted the
split-lib
branch
Aug 14, 2017
added a commit
to ideawake/agenda
that referenced
this pull request
Feb 16, 2018
OmgImAlexis commentedAug 12, 2017
I know this is another massive change but this was inevitable. The main file was getting way too large which meant every single time we have more than one person working on a section there's conflicts over the whole file. This fixes that as well as allowing us to setup debug more cleanly by each file having it's own debug field instead of every single function inside of
agenda.jsusingagenda:worker.@simison shall I just merge once the PR goes green? I'm more than happy to rebase any/all PRs that I've broken.