Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #505

Merged
merged 1 commit into from Aug 14, 2017
Merged

Update dependencies #505

merged 1 commit into from Aug 14, 2017

Conversation

@simison
Copy link
Member

simison commented Aug 14, 2017

  • Update cron and debug packages to latest
  • Set semver version range to more strict ~version ("Approximately equivalent to version") instead of ^version ("Compatible with version")

Note that debug has 3 breaking changes: https://github.com/visionmedia/debug/blob/master/CHANGELOG.md#300--2017-08-08

- Update `cron` and `debug` packages to latest
- Set semver version range to more strict `~version` ("Approximately equivalent to version") instead of `^version` ("Compatible with version")
@simison simison self-assigned this Aug 14, 2017
@simison simison requested a review from emhagman Aug 14, 2017
@simison

This comment has been minimized.

Copy link
Member Author

simison commented Aug 14, 2017

@emhagman you know about debug right?

Am I right that none of these affect us:

  • Breaking: Remove DEBUG_FD
  • Breaking: Use Date#toISOString() instead to Date#toUTCString() when output is not a TTY
  • Breaking: Make millisecond timer namespace specific and allow 'always enabled' output

(via debug changelog)

@simison

This comment has been minimized.

Copy link
Member Author

simison commented Aug 14, 2017

@emhagman WDYT, should I add another round of tests to Travis with debug turned on?

@OmgImAlexis

This comment has been minimized.

Copy link
Member

OmgImAlexis commented Aug 14, 2017

@simison checking the PRs for those show we aren't effected by any of the breaking changes.

LGTM.

@simison simison merged commit 09bef0e into master Aug 14, 2017
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@simison simison deleted the update-dependencies branch Aug 14, 2017
timelf123 added a commit to ideawake/agenda that referenced this pull request Feb 16, 2018
- Update `cron` and `debug` packages to latest
- Set semver version range to more strict `~version` ("Approximately equivalent to version") instead of `^version` ("Compatible with version")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.