Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Make job.touch() promise-based #667
This managed to slip through because the test for it changed at some point to mock out the implementation of
This PR makes the behavior of
Side note: this seems safe to treat as a bugfix rather than a breaking change because passing a callback to
@princjef would you mind updating the docs before we merge? If you don't have time for that, we can also loop back to it in a separate PR.
* origin/database-atlas: (47 commits) Changes to mongo atlas Fix: make `touch` promise-based (agenda#667) Update History.md with next version Update dependency sinon to v6.1.4 (agenda#663) Update dependency sinon to v6 (agenda#642) add deps:update to renovate auto labels (agenda#660) Update dependency mocha to v5 (agenda#640) Add a feature comparison table to readme (agenda#657) Feature/update deps (agenda#656) Update dependency delay to v3 (agenda#638) Mention promises based API in readme intro Update known issues in readme Update dependency coveralls to v3.0.2 (agenda#643) 2.0.0 Update changelog for v2.0.0 Update yarn lockfile (agenda#654) fix(database): use db() syntax rather than pulling dbName from client feat(database): upgrade mongodb -> 3.1 Update dependency sinon to v4.5.0 (agenda#636) Update dependency mocha to v4.1.0 (agenda#634) ...