Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.save and .remove return Promises and don't take callbacks #797

Merged
merged 2 commits into from Apr 3, 2019

Conversation

Projects
None yet
2 participants
@dandv
Copy link
Contributor

dandv commented Apr 3, 2019

See https://github.com/agenda/agenda/blob/master/lib/job/save.js for .save - it explicitly disallows passing a callback.

.remove should do the same, but it just doesn't call any callback - https://github.com/agenda/agenda/blob/master/lib/agenda/cancel.js

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
@wingsbob
Copy link
Contributor

wingsbob left a comment

LGTM

@wingsbob wingsbob merged commit 9e88934 into master Apr 3, 2019

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
security/snyk - package.json (agenda) No manifest changes detected

@dandv dandv deleted the dandv-fix-readme-save-remove branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.