Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node.js 8 support #925

Merged
merged 6 commits into from Feb 13, 2020
Merged

Drop Node.js 8 support #925

merged 6 commits into from Feb 13, 2020

Conversation

@simison
Copy link
Member

simison commented Feb 13, 2020

Drops Node.js 8 support. I mainly just wanted to update dependencies to the latest and at least xo (dev-dependency) isn't compatible with Node.js 8 anymore.

The maintenance period for 8 has finished anyway so I think this is an ok move: https://nodejs.org/en/about/releases/

@simison simison added the build tools label Feb 13, 2020
simison added 4 commits Feb 13, 2020
@MichielDeMey

This comment has been minimized.

Copy link
Member

MichielDeMey commented Feb 13, 2020

Makes sense to drop Node 8 since its maintenance period has expired. 👍

@simison

This comment has been minimized.

Copy link
Member Author

simison commented Feb 13, 2020

Thanks! @MichielDeMey you should join our volunteer Slack! :-) Link at the readme.

Copy link
Member

MichielDeMey left a comment

LGTM 👍

@simison simison merged commit 7f4ed46 into master Feb 13, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (agenda) No new issues
Details
@simison simison deleted the update/remove-nodejs-8-support branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.