Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarnings: autoReconnect, reconnectTries, reconnectInterval #948

Merged
merged 4 commits into from Feb 27, 2020

Conversation

@ekegodigital
Copy link
Contributor

ekegodigital commented Feb 24, 2020

I'm using the Docker Image mongo:3.6 and switched the "useUnifiedTopology" parameter to true as advised. If I do so I get the following deprecation warnings:

(node:51) DeprecationWarning: The option autoReconnect is incompatible with the unified topology, please read more by visiting http://bit.ly/2D8WfT6
(node:51) DeprecationWarning: The option reconnectTries is incompatible with the unified topology, please read more by visiting http://bit.ly/2D8WfT6
(node:51) DeprecationWarning: The option reconnectInterval is incompatible with the unified topology, please read more by visiting http://bit.ly/2D8WfT6

The fix checks if "useUnifiedTopology" is set and then doesn't use the deprecated options. If "useUnifiedTopology" isn't used, the options stay the same.

Eric Kesseler and others added 2 commits Feb 21, 2020
fix deprecated reconnect options
@MichielDeMey

This comment has been minimized.

Copy link
Member

MichielDeMey commented Feb 25, 2020

Thanks for this PR, before we can merge you need to make sure the linting/test pass on out CI. 😉

Eric Kesseler
Copy link
Member

MichielDeMey left a comment

One final remark 👍

lib/agenda/database.js Outdated Show resolved Hide resolved
Co-Authored-By: Michiel De Mey <de.mey.michiel@gmail.com>
Copy link
Member

MichielDeMey left a comment

Looks good!

@MichielDeMey MichielDeMey merged commit c75e46a into agenda:master Feb 27, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk (agenda) No manifest changes detected
Details
lkho added a commit to lkho/agenda that referenced this pull request Mar 24, 2020
…ul-shutdown

* 'master' of https://github.com/agenda/agenda: (58 commits)
  DeprecationWarnings: autoReconnect, reconnectTries, reconnectInterval (agenda#948)
  Update dependency eslint-plugin-ava to v10.2.0 (agenda#930)
  Fix for skipImmediate resetting nextRunAt to current date (agenda#860)
  Update dependency xo to v0.26.1 (agenda#926)
  Ability to set a skip when querying jobs. (agenda#898)
  3.0.0
  Update History.md
  Prepare v3.0.0 changelog
  Support of MongoDB: Unified Topology Design (agenda#921)
  Fix wrong path in DOCS (agenda#907)
  Update History.md
  Update dependency xo to v0.26.0 (agenda#922)
  Update dependency eslint-plugin-unicorn to v16 (agenda#920)
  Update dependency eslint-plugin-ava to v10 (agenda#912)
  Update dependency eslint-plugin-node to v11 (agenda#903)
  Drop Node.js 8 support (agenda#925)
  Update History.md
  Update History.md
  Update dependency mongodb to ~3.5.0 (agenda#910)
  Update dependency eslint-plugin-import to v2.20.1 (agenda#908)
  ...

# Conflicts:
#	lib/job/run.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.