[Bug] Agenda 4.2.1 produces an error on Agendash when rescheduling a job

[mg-83]

With the latest Version of Agendash there is an error (404 should be 500) thrown, when trying to do a reschedule on a job. It's working with Agenda 4.1.3 and 4.2.0 without problems.

[Nefsen402]

Hmm, it looks like anything both requeing or deleting jobs are affected. I drilled down into the issue, and it looks like the pkFactory is not a function anymore, but instead an object with an additional createPk function as a property. Agendash is assuming that pkFactory is a function and failing whenever it tries to modify or delete a job.

agendash/lib/controllers/agendash.js

Line 312 in bbb133f

_id: { $in: jobIds.map((jobId) => collection.s.pkFactory(jobId)) },

agendash/lib/controllers/agendash.js

Line 289 in bbb133f

_id: { $in: jobIds.map((jobId) => collection.s.pkFactory(jobId)) },

Here are the two references to the broken function.

Edit: I am having this issue with version 4.1.3 of Agenda which you mentioned was ok...
Edit again: No, I'm just jumping the gun, I was looking at package.json instead of package-lock.json. It indeed works on both versions you mentioned.

[nealoke]

When trying to reschedule a job in the UI you will get a 404 indeed. Quite blocking :(

[VadymKultenkoDarth]

Same here error 404 not found.

TypeError: collection.s.pkFactory is not a function

[ljacho]

It doesn't work

Hmm, it looks like anything both requeing or deleting jobs are affected. I drilled down into the issue, and it looks like the pkFactory is not a function anymore, but instead an object with an additional createPk function as a property. Agendash is assuming that pkFactory is a function and failing whenever it tries to modify or delete a job.

agendash/lib/controllers/agendash.js

Line 312 in bbb133f

_id: { $in: jobIds.map((jobId) => collection.s.pkFactory(jobId)) },

agendash/lib/controllers/agendash.js

Line 289 in bbb133f

_id: { $in: jobIds.map((jobId) => collection.s.pkFactory(jobId)) },

Here are the two references to the broken function.

Edit: I am having this issue with version 4.1.3 of Agenda which you mentioned was ok...
Edit again: No, I'm just jumping the gun, I was looking at package.json instead of package-lock.json. It indeed works on both versions you mentioned.

can you confirm it works for you with older versions please?

[ljacho]

Agenda is using new mongodb driver now, see ObjectId

fix: #193

[Shahor]

Is there anything planned to make this move forward?

[Shahor]

@santiq Sorry for pinging you directly but you seem to be the most active contributor.
Can you help on this maybe?

[GimpMaster]

Noticing this issue now. Following to see if it ever gets fixed. Otherwise Agendash is effectively a read-only tool now.

[scottbasgaard]

Same here.

[VadymKultenkoDarth]

what I did was just updated agendahs.js in Controller folder with these line 3 const { ObjectId } = require("mongodb"); line 45 preMatch[options.property] = ObjectId ( options.query ); line 289 _id: { $in: jobIds.map((jobId) => ObjectId(jobId)) }, line 312 _id: { $in: jobIds.map((jobId) => ObjectId(jobId)) },

…

________________________________ From: Scott Basgaard ***@***.***> Sent: Monday, January 24, 2022 5:08 PM To: agenda/agendash ***@***.***> Cc: Vadym Kultenko ***@***.***>; Comment ***@***.***> Subject: Re: [agenda/agendash] [Bug] Agenda 4.2.1 produces an error on Agendash when rescheduling a job (#191) Same here. — Reply to this email directly, view it on GitHub<#191 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHZX2W4TC7CUGJXZTW67CU3UXXLXXANCNFSM5CAXUDPQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you commented.Message ID: ***@***.***>

[koresar]

Merged the PR. Expect v3.0.0 soon.