Reorganize code#58
Conversation
|
Notes: ./tools is ambiguous WRT hack/tools and the only thing in tools/ is "setup" which is GCP specific (rename to setup-gcp?). What else might go in ./tools ? This is my only blocking question. ./pkg/api and ./pkg/proto are ambiguous -- they are both APIs, but for different layers. OK for now, but I expect we will want clarity on that eventually. Similarly ./pkg/client. Non-blocking |
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
fix/reorg_tool
branch
from
5c87071 to
e6216bb
Compare
Renamed tools/setup to tools/setup-gcp.
Agreed. I also added a third commit that deletes the tool at the tip. |
All rules are defined in rules.json. Then the tools/reorg tool will execute them.
This commit was automatically generated by the tools/reorg tool. ``` go run ./tools/reorg go generate ./... bash benchmarking/locust/generate_protos.sh ```
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
fix/reorg_tool
branch
from
e6216bb to
11e4466
Compare
Julian Gutierrez Oschmann (juli4n)
changed the title
|
LGTM |
|
Fire in the hole! |
3 participants
This PR has three commits, the first one introduces a tool to move / patch files within the repo to align with the rules enumerated in #49.
The second commit was automatically generated by running the tool (and go generate). This way we can rebase on top of inflight PRs, making the migration hopefully less painful.
The third one deletes the one-off tool.
Once the migration is done the tool will be removed so this PR should probably be not squashed (i.e. rebase and merge) to ease the rollback.
Fixes #49