Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea] remove lib/vendor #915

Closed
AienTech opened this Issue Nov 6, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@AienTech
Copy link

AienTech commented Nov 6, 2018

Hi there,

so, as the title suggests, why not remove lib/vendor and let users install composer dependencies using composer install?

@aheinze

This comment has been minimized.

Copy link
Member

aheinze commented Nov 7, 2018

Hi,

I want Cockpit as easy as it can be to setup and run for everyone (not only php developers). Just drop the files on a php enabled webserver and you‘re ready to go.

Plus, I support these arguments: https://www.codeenigma.com/build/blog/do-you-really-need-composer-production

@AienTech

This comment has been minimized.

Copy link
Author

AienTech commented Nov 7, 2018

Although I can't completely agree with the arguments stated in the blog post, I do understand your approach to make the project easier for other users. I personally added the vendor foler to gitignore and let the CI install dependencies for me.

another thing which came to my mind, me and my team are building a headless cms based on top of cockpit. Though it's kinda taking long time to understand the architecture of codes. Wouldn't it be nice to create a documentation for developers, so that they could also help on developing the project? (We would gladly help with development process if we have a blueprint of the project)

@aheinze

This comment has been minimized.

Copy link
Member

aheinze commented Nov 7, 2018

A headless cms on top of a headless cms !? 🤔 But I wish you the best 👍

Of course it would be nice to have a more detailed documentation, but it would be also nice to have time for that 😉

Cockpit is not a commercial product. I have contract work to do which will always have a higher priority as it pays the bills (+ enables Cockpits further development). Then I have also to do community support and maintain the current codebase. Btw. my family is also happy if spend some time with them 😉

So, I would like to invite you to dive into Cockpit and contribute to the docs taking the knowledge from what you'll learn. Cockpits codebase isn't that complicated, I always tried to keep it simple as possible.
There are plenty of addons for Cockpit already out there, made by people without having any prior touch points with Cockpit.

I hope you'll accept the challenge 😏

Greets,
Artur

@AienTech AienTech closed this Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.