refactor: support multiple API URLs per provider to allow flexible proxy routing and configuration#337
Merged
Merged
Conversation
…oxy routing and configuration
ankitranjan7
changed the title
ankitranjan7
requested review from
beubax and
manojbajaj95
and removed request for
manojbajaj95
| return (self.api_url,) | ||
| return tuple(url for url in self.api_url if isinstance(url, str) and url.strip()) | ||
|
|
||
| def primary_api_url(self) -> str | None: |
manojbajaj95
previously approved these changes
May 27, 2026
ankitranjan7
dismissed
manojbajaj95’s stale review
The merge-base changed after approval.
manojbajaj95
approved these changes
May 27, 2026
manojbajaj95
approved these changes
May 27, 2026
beubax
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow provider
api_urlto be configured as either a single string or a list of strings, and update proxy routing plus adjacent provider-handling code to support multiple host matches per provider.Motivation and Context
Some providers are authenticated across more than one host, but authsome currently models
api_urlas a single value. That makes proxy host matching too narrow for providers like GitHub.This change lets a provider declare multiple API hosts without forcing everything into one regex or one overly broad match.
How Has This Been Tested?
Tested with:
uv run ruff check src/ tests/uv run ty check src/uv run pytestTypes of changes
Checklist: