Add overlays for justboom and reorder #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
kraj
reviewed
Dec 27, 2020
|
@kraj fair enough. So just split into 2 different commits? But keeping on a single PR is ok? |
yes absolutely. |
shawaj
force-pushed
the
patch-3
branch
3 times, most recently
from
60d3264
to
9b8b3bc
Compare
reorder list to be in alphabetical order Change-type: patch Signed-off-by: Aaron Shaw <aaron@balena.io>
add justboom overlays Change-type: patch Signed-off-by: Aaron Shaw <shawaj@gmail.com>
|
@kraj fixed now :-) |
|
@kraj does the CI need to test build? How do I / we trigger that? |
it should start on pull request refresh or push |
|
@kraj it doesn't seem to have worked since my last updates? |
|
@agherzan-ci ok to test |
1 similar comment
|
@agherzan-ci ok to test |
agherzan
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overlays for justboom audio boards and reorder list to be in alphabetical order
Change-type: patch
Signed-off-by: Aaron Shaw aaron@balena.io