From 01d8cff0d8896cb003fef6df6db594de167489cb Mon Sep 17 00:00:00 2001 From: Yuan Tang Date: Wed, 10 May 2023 14:38:13 -0400 Subject: [PATCH] chore: Bump killDuration for signals_test.go to avoid flaky test result (#11064) Signed-off-by: Yuan Tang --- test/e2e/signals_test.go | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/test/e2e/signals_test.go b/test/e2e/signals_test.go index 2e116f12362a..2b7f047a0744 100644 --- a/test/e2e/signals_test.go +++ b/test/e2e/signals_test.go @@ -15,7 +15,7 @@ import ( "github.com/argoproj/argo-workflows/v3/test/e2e/fixtures" ) -const kill2xDuration = 70 * time.Second +const killDuration = 75 * time.Second // Tests the use of signals to kill containers. // argoproj/argosay:v2 does not contain sh, so you must use argoproj/argosay:v1. @@ -29,9 +29,9 @@ func (s *SignalsSuite) TestStopBehavior() { Workflow("@functional/stop-terminate.yaml"). When(). SubmitWorkflow(). - WaitForWorkflow(fixtures.ToHaveRunningPod, kill2xDuration). + WaitForWorkflow(fixtures.ToHaveRunningPod, killDuration). ShutdownWorkflow(wfv1.ShutdownStrategyStop). - WaitForWorkflow(kill2xDuration). + WaitForWorkflow(killDuration). Then(). ExpectWorkflow(func(t *testing.T, m *metav1.ObjectMeta, status *wfv1.WorkflowStatus) { assert.Contains(t, []wfv1.WorkflowPhase{wfv1.WorkflowFailed, wfv1.WorkflowError}, status.Phase) @@ -55,9 +55,9 @@ func (s *SignalsSuite) TestStopBehaviorWithDaemon() { Workflow("@functional/stop-terminate-daemon.yaml"). When(). SubmitWorkflow(). - WaitForWorkflow(fixtures.ToHaveRunningPod, kill2xDuration). + WaitForWorkflow(fixtures.ToHaveRunningPod, killDuration). ShutdownWorkflow(wfv1.ShutdownStrategyStop). - WaitForWorkflow(kill2xDuration). + WaitForWorkflow(killDuration). Then(). ExpectWorkflow(func(t *testing.T, m *metav1.ObjectMeta, status *wfv1.WorkflowStatus) { assert.Contains(t, []wfv1.WorkflowPhase{wfv1.WorkflowFailed, wfv1.WorkflowError}, status.Phase) @@ -73,9 +73,9 @@ func (s *SignalsSuite) TestTerminateBehavior() { Workflow("@functional/stop-terminate.yaml"). When(). SubmitWorkflow(). - WaitForWorkflow(fixtures.ToHaveRunningPod, kill2xDuration). + WaitForWorkflow(fixtures.ToHaveRunningPod, killDuration). ShutdownWorkflow(wfv1.ShutdownStrategyTerminate). - WaitForWorkflow(kill2xDuration). + WaitForWorkflow(killDuration). Then(). ExpectWorkflow(func(t *testing.T, m *metav1.ObjectMeta, status *wfv1.WorkflowStatus) { assert.Contains(t, []wfv1.WorkflowPhase{wfv1.WorkflowFailed, wfv1.WorkflowError}, status.Phase) @@ -96,9 +96,9 @@ func (s *SignalsSuite) TestDoNotCreatePodsUnderStopBehavior() { Workflow("@functional/stop-terminate-2.yaml"). When(). SubmitWorkflow(). - WaitForWorkflow(fixtures.ToHaveRunningPod, kill2xDuration). + WaitForWorkflow(fixtures.ToHaveRunningPod, killDuration). ShutdownWorkflow(wfv1.ShutdownStrategyStop). - WaitForWorkflow(kill2xDuration). + WaitForWorkflow(killDuration). Then(). ExpectWorkflow(func(t *testing.T, m *metav1.ObjectMeta, status *wfv1.WorkflowStatus) { assert.Equal(t, wfv1.WorkflowFailed, status.Phase) @@ -116,7 +116,7 @@ func (s *SignalsSuite) TestSidecars() { Workflow("@testdata/sidecar-workflow.yaml"). When(). SubmitWorkflow(). - WaitForWorkflow(fixtures.ToBeSucceeded, kill2xDuration) + WaitForWorkflow(fixtures.ToBeSucceeded, killDuration) } // make sure Istio/Anthos and other sidecar injectors will work @@ -125,7 +125,7 @@ func (s *SignalsSuite) TestInjectedSidecar() { Workflow("@testdata/sidecar-injected-workflow.yaml"). When(). SubmitWorkflow(). - WaitForWorkflow(fixtures.ToBeSucceeded, kill2xDuration) + WaitForWorkflow(fixtures.ToBeSucceeded, killDuration) } func (s *SignalsSuite) TestSubProcess() {