Add Global Iris RealAuth gateway and RealMPI integration #99

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@spookylukey
Contributor

spookylukey commented Feb 24, 2014

This is a fairly large patch, but it is fully tested, and was implemented test driven from the beginning. (88% and 95% code coverage for the two main modules).

It also includes docs, including a (stripped down) version of the code you need to bind it all together (which I developed hand-in-hand with the billing code.

In order to implement this, I added a few completely backwards compatible conveniences to other parts of the code base:

  • CreditCard now accepts cardholder_name as an alternative to first_name and last_name. (I've never seen a credit card form that accepts first/last name, actually). Tested and documented.
  • billing.forms.common.CreditCardFormBase - a base class that has some conveniences for creating credit card forms. Only used by billing.forms.global_iris_forms.CreditCardForm currently. Tested and documented with docstrings. The Global Iris docs also have an example of it being used.
  • billing.tests.utils.BetterXMLCompareMixin - provides "assertXMLEqual" which is like Django's, but much more helpful at locating the differences between some chunks of XML.
@tuxcanfly

This comment has been minimized.

Show comment Hide comment
@tuxcanfly

tuxcanfly Feb 26, 2014

Member

@spookylukey Where do I sign up for a test account? I can only find this form which doesn't look like a auto signup form to me:

http://www.globalpaymentsinc.co.uk/newenquiryform.html

Member

tuxcanfly commented Feb 26, 2014

@spookylukey Where do I sign up for a test account? I can only find this form which doesn't look like a auto signup form to me:

http://www.globalpaymentsinc.co.uk/newenquiryform.html

@tuxcanfly tuxcanfly closed this Feb 26, 2014

@tuxcanfly tuxcanfly reopened this Feb 26, 2014

@spookylukey

This comment has been minimized.

Show comment Hide comment
@spookylukey

spookylukey Feb 26, 2014

Contributor

You can't sign up for a test account, as far as I know. You need a business account with Global Payments. It's possible that they might give you an account as a maintainer of a package that integrates with Global Iris - it certainly would be in their interests to do so.

I have a set of test card numbers, and have run the tests with these as documented. However, I was given them on the condition of non-disclosure. You can run most of the tests without these card numbers though.

Contributor

spookylukey commented Feb 26, 2014

You can't sign up for a test account, as far as I know. You need a business account with Global Payments. It's possible that they might give you an account as a maintainer of a package that integrates with Global Iris - it certainly would be in their interests to do so.

I have a set of test card numbers, and have run the tests with these as documented. However, I was given them on the condition of non-disclosure. You can run most of the tests without these card numbers though.

tuxcanfly added a commit that referenced this pull request Feb 26, 2014

@tuxcanfly

This comment has been minimized.

Show comment Hide comment
@tuxcanfly

tuxcanfly Feb 26, 2014

Member

OK, I'll leave it at that.

Thanks @spookylukey!

Member

tuxcanfly commented Feb 26, 2014

OK, I'll leave it at that.

Thanks @spookylukey!

@tuxcanfly tuxcanfly closed this Feb 26, 2014

@spookylukey

This comment has been minimized.

Show comment Hide comment
@spookylukey

spookylukey Feb 26, 2014

Contributor

Great, thank you!

Contributor

spookylukey commented Feb 26, 2014

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment