David Siegel agnat

  • Berlin
  • Joined on
agnat commented on pull request iojs/nan#331
@agnat

Not sure about this. Maybe it has been discussed elsewhere but isn't this a perfect application for a persistent with copy semantics? Non-copyable …

agnat commented on issue iojs/nan#289
@agnat

As of now, I think NanNew should always return a NanMaybeLocal if T is Script, Date or RegExp I think you can switch those to return maybe-foo by…

agnat commented on issue iojs/nan#289
@agnat

Is it possible to break up the NanNew factories so they can return Local for some arguments to NanNew and NanMaybeLocal for other args? Nope. Not…

agnat commented on issue agnat/node_mdns#130
@agnat

Thanks for looking into this. Should this solution be integrated into master? Not sure yet. Needs closer inspection. In any case you guys can pas…

agnat commented on issue agnat/node_mdns#108
@agnat

Nope. Wild-ass guessing based on the OS is exactly what library code should not do. It would break on older Mac OS versions and for anybody using m…

agnat commented on issue agnat/node_mdns#108
@agnat

Any chance you could tell us a long story? :) Short version of a long story is: Since node switched the build system from waf to gyp a few years …

agnat closed issue agnat/node_mdns#129
@agnat
Issue with avahi on raspberry pi 2
agnat commented on issue agnat/node_mdns#130
@agnat

As I said: I think it's a name service switch thing. Read the nsswitch.conf man page... Specifically: The service specifications supported on your…

agnat commented on issue agnat/node_mdns#130
@agnat

This issue, states that it's fair to ignore the warnings. Yup. But what about the two errors? It is a system/config thing on the raspberry. My …

agnat commented on issue agnat/node_mdns#38
@agnat

Please see the section on installation in the README.

agnat commented on pull request agnat/node_wake_on_lan#3
@agnat

Indentation: Looks like another tab. Please use grep or something to look for others...

agnat commented on pull request agnat/node_wake_on_lan#3
@agnat

Indentation: Is that a tab?

agnat commented on pull request agnat/node_wake_on_lan#3
@agnat

Yeah, well. You verified it on one platform. However, Unix Network Programming says I'm right... which is good enough for me. Now, why keep the por…

agnat commented on pull request agnat/node_wake_on_lan#3
@agnat

IIRC using port 0 is what you want. But this is your contribution. So, look it up... ;)

agnat commented on pull request agnat/node_wake_on_lan#3
@agnat

Setting a source address makes sense. However, IMO setting a port doesn't. On the contrary. By letting the OS pick a port the old code avoided all …

agnat commented on pull request iojs/io.js#1125
@agnat

@bnoordhuis, ah ok. My bad. I somehow had the impression they are all single file demos. High coding standards are not antithetical to effective d…

agnat commented on pull request iojs/io.js#1125
@agnat

+1 for high coding standards in examples. On a side note: I'd use an anonymous namespace instead of namespace demo. It is paste-proof and hardly an…

agnat commented on issue agnat/node_mdns#129
@agnat

[...] should I do something about it? Yes, please. That would be awesome. Thanks! Just kidding... Ignore the warning. The stuff you'll need is pr…

agnat commented on issue agnat/node_mdns#128
@agnat

Again, please read the section on error handling. Also take a look at the error message in your initial post. You're going to need an error event h…

agnat commented on issue agnat/node_mdns#128
@agnat

The main problem is omission of error handling in real-world code. See error handling for details. Cheers.

agnat commented on issue rvagg/nan#287
@agnat

Because imageFile is a std::string, not a v8::String. Try NanReturnValue(NanNew(imageFile));

agnat commented on issue agnat/node_mdns#125
@agnat

Is there any reason why you didn't wrap this line [...] as well? Yes. If the call to DNSServiceRegister(...) succeeds the service record is always

agnat commented on issue agnat/node_mdns#125
@agnat

What was the use of this "fix" ? See #123.

agnat commented on issue agnat/node_mdns#125
@agnat

Fixed in v2.2.8.

agnat created tag v2.2.8 at agnat/node_mdns
@agnat
agnat closed issue agnat/node_mdns#125
@agnat
DNSServiceRef is not initialized
agnat commented on issue agnat/node_mdns#125
@agnat

Probably real... unfortunately. It's caused by a recent ... uh ... fix :-/ Let me think about it for a few. To work around it either remove the off…

agnat commented on pull request agnat/node_mdns#123
@agnat

Published in v2.2.7.

agnat created tag v2.2.7 at agnat/node_mdns