7ochem/prevent php notice undefined index #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the response has 'users' set. In case of an error returned by the API, $response['users'] is not set and a notice like "ERR (3): Notice: Undefined index: user in src/app/code/community/Zendesk/Zendesk/Model/Api/Users.php" will appear in the logs
Contributor
Author
|
@jwswj can you please check this? |
Contributor
|
+1 |
Contributor
Author
|
@joseconsador can this be reviewed and merged? It is a minor change with a huge impact for us... |
Contributor
|
👍 |
joseconsador
added a commit
that referenced
this pull request
Jan 4, 2016
…ed-index 7ochem/prevent php notice undefined index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the response has 'users' set. In case of an error returned by the API,
$response['users']is not set and a notice like "ERR (3): Notice: Undefined index: user in src/app/code/community/Zendesk/Zendesk/Model/Api/Users.php" will appear in the logs