Proposed fix for https://github.com/zendesk/magento_extension/issues/85

[dave-swift]

Fix for #85, which addresses the assumption Mage::app()->getFrontController() is always set. It's best to see the comments in the ticket.

The short of it is that it removes Mage::app()->getFrontController() from the observer model since observers are not always called from a controller (eg, API, cron, command line, etc).

[joseconsador]

@dave-swift Thanks for this. Can you add a description in the PR though. We're reviewing it now.

Jose

[RoussKS]

Hi,

Is this PR going to be accepted or will there be a fix for this issue?
We have similar issues using Magento's API to create orders.
Magento version is 1.9.2.4 fully patched until the latest SUPEE-10415

Many Thanks

[schmengler]

I can confirm that it is impossible to create orders via API with the extension, because getFrontController() returns null during API requests, but blocks are rendered for the order confirmation email.

This is a serious problem and the PR solves it, so please include it in the next release. If you hesitate because it changes too much, a simple fix would be to include the following lines at the beginnning of the observer methods setHook and insertBlock

    if (! Mage::app()->getFrontController()->getAction()) {
        return;
    }

[yifeiwu]

@joseconsador