Fix wrong condition, results in the snippet always being re-saved. #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bad condition introduced in: ca2f69f Fortunately, there is no bug caused by this. Just resulted in the snippet always being stored in the db every time the config is saved, one unnecessary write though.
joseconsador
approved these changes
Feb 8, 2018
jmramos02
approved these changes
Feb 8, 2018
miogalang
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @zendesk/mintegrations
Description
This fixes a bad condition I introduced in this commit: ca2f69f
There was a typo in the variable name and the if condition was incorrect 🤦♂️
Fortunately, there is no bug caused by this. The bad condition just resulted in the snippet always being stored in the db every time the config is saved, one unnecessary write. Ironically enough, it was because of the variable typo that the bad if-condition did not cause a bug.
Risks