From 5ebca7fcc5690cdca3e63a94a2bc2909db8a033e Mon Sep 17 00:00:00 2001 From: Sam Gavinio Date: Thu, 8 Feb 2018 16:36:54 +0800 Subject: [PATCH] Fix wrong condition, results in the snippet always being re-saved. This fixes a bad condition introduced in: https://github.com/zendesk/magento_extension/pull/132/commits/ca2f69f918272f33f63fe52b9c5994f155850033 Fortunately, there is no bug caused by this. Just resulted in the snippet always being stored in the db every time the config is saved, one unnecessary write though. --- src/app/code/community/Zendesk/Zendesk/Model/Observer.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app/code/community/Zendesk/Zendesk/Model/Observer.php b/src/app/code/community/Zendesk/Zendesk/Model/Observer.php index 30559d9c..708fa7ed 100644 --- a/src/app/code/community/Zendesk/Zendesk/Model/Observer.php +++ b/src/app/code/community/Zendesk/Zendesk/Model/Observer.php @@ -111,8 +111,8 @@ public function saveConfig(Varien_Event_Observer $observer) } // Case insensitive search with single and double quotes, still better performance than 1 regexp search - $hasUnatchedSnippet = stripos($widgetSnippet, "'{$zDomain}'") === false && stripos($widgetSnippet, '"'.$zDomain.'"') === false; - if (! $hasUnmatchedSnippet) { + $missingSnippet = stripos($widgetSnippet, "'{$zDomain}'") === false && stripos($widgetSnippet, '"'.$zDomain.'"') === false; + if ($missingSnippet) { $webWidgetSnippet=<<