New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails’ UJS adapter causes confirm loop #9

Closed
jletourneau opened this Issue Jun 19, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@jletourneau
Contributor

jletourneau commented Jun 19, 2014

When the Rails unobtrusive JavaScript adapter (https://github.com/rails/jquery-ujs) is in place on a page, links or forms with both the data-method and data-confirm attribute (e.g. links that perform a delete) cannot be properly confirmed: a new confirmation modal comes up each time you hit OK on the previous.

@jletourneau jletourneau added the bug label Jun 19, 2014

@jletourneau

This comment has been minimized.

Show comment
Hide comment
@jletourneau

jletourneau Jun 19, 2014

Contributor

I looked into this a bit last night and may end up needing to rework some of the structure of the data attributes this plugin uses. Going to feel it out a little more and see what I can do.

Contributor

jletourneau commented Jun 19, 2014

I looked into this a bit last night and may end up needing to rework some of the structure of the data attributes this plugin uses. Going to feel it out a little more and see what I can do.

@jletourneau

This comment has been minimized.

Show comment
Hide comment
@jletourneau

jletourneau Jul 25, 2014

Contributor

Fortunately, the fix for this did not entail any usage changes, so I've tagged it with a bugfix release number (1.0.1). Should be all set now, with or without jquery_ujs.js in play.

Contributor

jletourneau commented Jul 25, 2014

Fortunately, the fix for this did not entail any usage changes, so I've tagged it with a bugfix release number (1.0.1). Should be all set now, with or without jquery_ujs.js in play.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment