Skip to content
This repository was archived by the owner on Apr 8, 2026. It is now read-only.

ASC sorted page_for was broken due to a spelling error#6

Closed
simonklee wants to merge 1 commit into
WB-Games:masterfrom
simonklee:page_for-fix
Closed

ASC sorted page_for was broken due to a spelling error#6
simonklee wants to merge 1 commit into
WB-Games:masterfrom
simonklee:page_for-fix

Conversation

@simonklee

Copy link
Copy Markdown

I tried to create a test for this but I wasn't able to get that test suite thing to work.

True.should.be(False)

wasn't even raising an error. Never used the testing library before so I might have done something wrong.

@czarneckid

Copy link
Copy Markdown
Contributor

I'll put in a section in the README on running the tests. I use virtualenv, so it consists of:

mkvirtualenv leaderboard-python
workon leaderboard-python
pip install -r requirements.pip
./run_tests

@simonklee

Copy link
Copy Markdown
Author

I was able to run them, but they did simply not fail. Even when I put in a statement like I demonstrated above.

@czarneckid

Copy link
Copy Markdown
Contributor

I think it has to do with the be() function. I should probably change them all to equal() where appropriate. be() may just be testing for truthyness.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants