Skip to content

Multiple javascript executions when including a tag multiple times #65

Closed
moritzp opened this Issue Apr 4, 2014 · 4 comments

2 participants

@moritzp
moritzp commented Apr 4, 2014

If including the a js dependent view more than once, the javascript is also included more than once, which leads to multiple executions of the script and therefore multiple popups etc.

@benorama
AgoraPulse member
benorama commented Apr 4, 2014

Indeed, since 0.6.0, this is an issue.
We might put some variables in the request scope to prevent multiple inserts...
I'm going to have a look on this.

@moritzp
moritzp commented Apr 4, 2014

I already committed something you might want to check it out:
moritzp@153373c

@benorama benorama added a commit that closed this issue Apr 4, 2014
@benorama benorama [Fix #65] TagLib update (scripts are only included once in a page eve…
…n if tags are used more than once)
a202f49
@benorama benorama closed this in a202f49 Apr 4, 2014
@benorama
AgoraPulse member
benorama commented Apr 4, 2014

Hi Moritz,

I've updated the tag lib to automatically record included scripts so that there are only include once.
I just released 0.6.1.
Let me know if it solves your issue.

Thanks for the bug report!

@moritzp
moritzp commented Apr 4, 2014

Indeed, yours is a nicer solution :) Works for us! Thanks for the quick fix!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.