New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses with Suites #22

Closed
steveoh opened this Issue Mar 4, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@steveoh
Member

steveoh commented Mar 4, 2016

sterlingpetersen@utah.gov

I've run across something that might be a small bug in the geocoding API. I didn't do thorough testing, but it appears that if a suite number on an address contains an alpha character, the geocoding fails:

http://api.mapserv.utah.gov/api/v1/geocode/1151 E 3900 S Ste B150/84107?spatialReference=4326&pobox=true&apiKey=AGRC-ApiExplorer

vs.

http://api.mapserv.utah.gov/api/v1/geocode/1151 E 3900 S Ste 150/84107?spatialReference=4326&pobox=true&apiKey=AGRC-ApiExplorer

@steveoh steveoh added the bug label Mar 4, 2016

@steveoh

This comment has been minimized.

Show comment
Hide comment
@steveoh

steveoh Apr 20, 2016

Member

this is fixed but not deployed yet. I had to update the assumptions on how secondary addresses are designed.

Member

steveoh commented Apr 20, 2016

this is fixed but not deployed yet. I had to update the assumptions on how secondary addresses are designed.

@steveoh

This comment has been minimized.

Show comment
Hide comment
@steveoh

steveoh Apr 21, 2016

Member

deployed.

Member

steveoh commented Apr 21, 2016

deployed.

@steveoh steveoh closed this Apr 21, 2016

@steveoh

This comment has been minimized.

Show comment
Hide comment
@steveoh

steveoh Jul 22, 2016

Member

Thanks for the report. Ill have to check what is up a little close next week. I would assume this should work because we check for suites https://github.com/agrc/api.mapserv.utah.gov/blob/master/WebAPI.API/App_Start/CacheConfig.cs#L184

Member

steveoh commented Jul 22, 2016

Thanks for the report. Ill have to check what is up a little close next week. I would assume this should work because we check for suites https://github.com/agrc/api.mapserv.utah.gov/blob/master/WebAPI.API/App_Start/CacheConfig.cs#L184

@steveoh steveoh reopened this Jul 22, 2016

@steveoh steveoh closed this in 2353f7e Jul 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment