Fix exit status when parsing error occurs in pgagroal-cli #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, a parsing error in pgagroal-cli would return an exit status of 0, indicating success. This commit resolves the issue by setting `exit_error = 1;` after a parsing error, ensuring it properly returns the correct error status to the caller.
|
Looks fine to me. |
|
Rebased, and merged. Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting in #427, I found out that
pgagroal-clireturns an exit status of 0, indicating success to the caller, if a command parsing error occurs.This commit resolves the issue by setting
exit_error = 1;after a parsing error, ensuring it properly returns the correct error status to the caller.Notice that the same does not occur with
pgagroal-admin(it has a different way of handling errors --goto error, whilepgagroal-cligoes to the same label --done).