Skip to content
Commits on Jan 20, 2013
  1. update README with status of python-lvm

    committed with Jan 19, 2013
    merged into lvm2, no longer actively maintained separately.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on Dec 6, 2012
  1. Fix Py_BuildValue for i386

    James Antill committed with Dec 5, 2012
    see https://bugzilla.redhat.com/show_bug.cgi?id=881989
    
    Signed-off-by: James Antill <james.antill@redhat.com>
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on Oct 26, 2012
  1. @tasleson

    Memory leaks & seg. fault fixes

    tasleson committed with Oct 26, 2012
    Added Py_DECREF(ptr) in liblvm_lvm_vg_open & liblvm_lvm_vg_create
    in error paths so that we correctly clean up memory.
    
    Added a call to lvm_vg_close when we remove a vg.  The code was
    clearing out the vg pointer which prevented us from actually
    calling lvm_vg_close in the close path.
    
    liblvm_lvm_vg_create_lv_linear was not initializing
    lvobj->parent_vgobj and if lvm_vg_create_lv_linear failed
    we went through liblvm_lv_dealloc on clean up and tried to
    Py_DECREF an invalid pointer.
    
    Signed-off-by: Tony Asleson <tasleson@redhat.com>
Commits on Oct 17, 2012
  1. whitespace, arrgh

    committed Oct 17, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on Oct 16, 2012
  1. Implement proper refcounting for parent objects

    committed Oct 16, 2012
    Our object nesting:
    
    lib -> VG -> LV -> lvseg
              -> PV -> pvseg
    
    Implement refcounting and checks to ensure parent objects are not
    dealloced before their children. Also ensure calls to self or child's
    methods are handled cleanly for objects that have been closed or removed.
    
    Ensure all functions that are object methods have a first parameter named
    'self', for consistency
    
    Rename local vars that reference a Python object to '*obj', in order to
    differentiate from liblvm handles
    
    Fix a misspelled pv method name
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  2. Also ifdef percent_to_float

    committed Oct 16, 2012
    unsupported in 2.2.97.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  3. lvm_lv_rename not supported in 2.2.97

    committed Oct 16, 2012
    Just ifdef out, for when/if we move up the minimum version
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on Oct 15, 2012
  1. update minimum version

    committed Oct 15, 2012
    We support lvm_config_add_bool, added in .97
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  2. Rename test.py -> example.py

    committed Oct 15, 2012
    synced from lvm2.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  3. remove liblvm object

    committed Oct 15, 2012
    Instead of requiring users to create a liblvm object, and then calling
    methods on it, the module acquires a liblvm handle as part of
    initialization. This makes it impossible to instantiate a liblvm object
    with a different systemdir, but there is an alternate envvar method for
    that obscure use case.
    
    Also, fix whitespace and Yoda conditionals.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  4. sync with lvm2-2.2.98

    committed Oct 15, 2012
    python-lvm is part of lvm2 now. see:
    
    git://git.fedorahosted.org/lvm2.git
    
    Sync this repo with changes made there up to v2.2.98.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on Sep 17, 2012
  1. @tasleson

    test.py expanded example.

    tasleson committed with Sep 17, 2012
    Signed-off-by: Tony Asleson <tasleson@redhat.com>
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on Sep 13, 2012
  1. README: Add minimum LVM version. Closes #1

    committed Sep 13, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on May 21, 2012
  1. setup.py version 1.2.3

    committed May 21, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
  2. Add valid-object checking for lvmobject

    committed May 21, 2012
    If .close() has been called then we can't use it any more.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on May 15, 2012
  1. Set lvm_obj when calling vgOpen

    committed May 15, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
  2. Move decrefs after PyErr_SetObject

    committed May 15, 2012
    liblvm_get_last_error makes lvm calls, do not free self until it is
    done building exception object.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  3. update to 1.2.2

    committed May 14, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on May 14, 2012
  1. define tp_new so things work

    committed May 14, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
  2. update to version 1.2

    committed May 14, 2012
    update liblvm.c copyright header to not have an address in it
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on May 12, 2012
  1. upgrade to BETA status

    committed May 11, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
  2. Do not allow methods to be called on invalid VGs and LVs

    committed May 11, 2012
    If an object has .remove called on it, we cannot use the LVM API any more
    but the Python object still exists. Add VG_VALID and LV_VALID macros and
    use in all method calls to ensure we throw an exception in this case.
    
    Not done for PVs since they cannot be removed via liblvm as yet.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on May 11, 2012
  1. More cleanups

    committed May 11, 2012
    Rename rv to pytuple
    
    Don't need goto-style error handling since there is only one conditional
    that can fail that needs it. dm_list_empty check is extraneous.
    
    Whitespace
    
    Return None instead of rval for methods that do something
    
    Don't close vg if operations fail
    
    Check for failure of PyObject_New()
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  2. remove casts in calls to liblvm_get_last_error()

    committed May 11, 2012
    Keep a reference to the base lvmobject in secondary classes so
    liblvm_get_last_error can be called with it.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  3. Rewrite liblvm_lvm_vg_list_pvs

    committed May 11, 2012
    Properly handly liblvm API weirdness for lvm_vg_list_vgs
    
    handle PyObject_New returning NULL
    
    Rename local variable name for clarity
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  4. free python objects if liblvm calls fail

    committed May 11, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
  5. Add self to authors

    committed May 11, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
  6. Untabify and set emacs indent settings

    committed May 11, 2012
    I thought I did this before... oh well whatever. We're using python
    indent settings (4 space indent) for this.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  7. fix clustred typo

    committed May 11, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on May 2, 2012
  1. Don't define tp_getattr for types

    committed May 1, 2012
    The default implementation (PyObject_GenericGetAttr) should be ok.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  2. Use C99 initializations for type objects

    committed May 1, 2012
    Also, since they are not variable length, use PyObject_HEAD_INIT instead
    of PyVarObject_HEAD_INIT.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on May 1, 2012
  1. update setup.py to 1.1.1

    committed May 1, 2012
    Signed-off-by: Andy Grover <agrover@redhat.com>
  2. update more FSF addresses.

    committed May 1, 2012
    seriously?
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
  3. fix int parsing in vg.createLvLinear()

    committed May 1, 2012
    overflow.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
Commits on Apr 17, 2012
  1. More fixes for liblvm -> lvm

    committed Apr 17, 2012
    Module should be imported as 'lvm'.
    Shared object should be lvm.so.
    
    Signed-off-by: Andy Grover <agrover@redhat.com>
Something went wrong with that request. Please try again.