feat: add agent availability roles#52
Conversation
Test & Lint Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the implementation. I found blocking issues: the PR currently fails to build because the generated API bindings do not include the new proto types, and the role set/remove flows can leave the database and OpenFGA authorization state inconsistent on partial failure. Requesting changes.
|
Addressed Noa's requested changes:
Validation:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the fixes. The DB/OpenFGA rollback handling now addresses my previous consistency comments, but CI is still failing in the updated protobuf generation workflow before tests/build run. Requesting changes until the workflow is green.
noa-lucent
left a comment
There was a problem hiding this comment.
Refreshed at head 17a5cb1. The role consistency fixes are still good, but the PR remains blocked because CI is still failing in protobuf generation before tests/build run. The unresolved CI workflow comment still applies.
|
Fixed the remaining CI protobuf generation issue in the same PR/branch. What changed:
Validation:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-review complete at head 9650cb7. The protobuf generation workflow now runs without the bad move step, CI is green (go test ./... and go build ./... pass), and the previous role consistency fixes remain in place. Approved.
Summary
Validation
Closes #51