Improved code

aheckmann · Jul 12, 2015 · dd81426 · dd81426
1 parent 26a9947
commit dd81426
Showing 1 changed file with 13 additions and 19 deletions.
diff --git a/test/resizeWrong.js b/test/resizeWrong.js
@@ -7,36 +7,30 @@ module.exports = function (_, dir, finish, gm) {
 
   var original = dir + '/original.png';
   var resized = dir + '/resize';
-  var widths = [600, 700, 400, 800], i, cb;
+  var widths = [300, 700, 400, 800, 200], i, cb;
+  var resize = function (width, index) {
+    var name = resized + index + '.png';
 
-  var resize = function (width, resized, cb) {
-    console.log('resized', resized);
-    console.log('width', width);
+    if (index == widths.length) {
+      return finish();
+    } else {
+      index++;
+    }
     gm(original)
       .resize(width)
-      .write(resized, function(err){
+      .write(name, function(err){
         if (err) return finish(err);
 
-        gm(resized)
+        gm(name)
           .size(function (err, size) {
             if (err) return finish(err);
             if (size.width !== width) return finish("Wrong resizing on requested:" + width + ", resized:" + size.width);
 
-            if (cb) cb();
-            else finish();
+            if (cb) return cb();
+            resize(widths[index], index);
           });
       });
   };
 
-  for (i = 0; i < widths.length; i++) {
-    if (i < widths.length - 2) {
-      cb = function () {
-        resize(widths[i + 1]);
-      };
-    } else {
-      cb = null;
-    }
-
-    resize(widths[i], resized + i + '.png', cb);
-  };
+  resize(widths[0], 0);
 }