Skip to content

New signature for GridReadStream and GridWriteStream #16

Closed
wants to merge 3 commits into from

2 participants

@Reggino
Collaborator
Reggino commented Apr 6, 2013

Since the use of filename and objectId are ambiguous, the signature of GridReadStream, GridWriteStream and remove() are updated so it takes a single options parameter. As discussed with @aheckmann in issue #11

Note that this change is NOT backwards compatible and thus the version is bumped to 0.4.0.

@Reggino Reggino Update Readme.md
Updated signature of createWriteStream, createWriteStream and remove
2df7edb
@Reggino
Collaborator
Reggino commented Apr 6, 2013

This fixes issues #4, #6, #7, #10 and #11 .

#15 is fixed too (more or less) by adding some documentation.

@aheckmann aheckmann commented on the diff Apr 6, 2013
package.json
@@ -2,7 +2,7 @@
"author": "Aaron Heckmann <aaron.heckmann+github@gmail.com>",
"name": "gridfs-stream",
"description": "Writable/Readable Nodejs compatible GridFS streams",
- "version": "0.3.2",
+ "version": "0.4.0",
"keywords": [
@aheckmann
Owner
aheckmann added a note Apr 6, 2013

lets bump version in a separate commit. we'll update History.md at same time with a new tag.

@Reggino
Collaborator
Reggino added a note Apr 7, 2013

I've updated the commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@aheckmann
Owner

merged. Thanks! 0.4.0 is out.

@aheckmann aheckmann closed this Apr 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.