Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "last updated" date to data returned from REST endpoint #18

Closed
smbyers opened this issue Mar 22, 2020 · 6 comments
Closed

Add "last updated" date to data returned from REST endpoint #18

smbyers opened this issue Mar 22, 2020 · 6 comments
Assignees

Comments

@smbyers
Copy link

@smbyers smbyers commented Mar 22, 2020

Include the date when the data was last updated in the response from the REST endpoint at ttps://corona.lmao.ninja

@floturcocantsee

This comment has been minimized.

Copy link
Contributor

@floturcocantsee floturcocantsee commented Mar 23, 2020

Pull #20 adds this functionality at the end of the program's output. @smbyers

@smbyers

This comment has been minimized.

Copy link
Author

@smbyers smbyers commented Mar 23, 2020

I was interested in seeing the last updated from data source (https://corona.lmao.ninja) endpoint that is called by the CLI to understand when that data point came in. It may also be valuable to see when the CLI was called but that does not tell the age of the actual data that is from the endpoint.

@floturcocantsee

This comment has been minimized.

Copy link
Contributor

@floturcocantsee floturcocantsee commented Mar 23, 2020

@smbyers the code gets the updated time from the API at this endpoint: https://corona.lmao.ninja/all.
Most of the code is just formatting and converting it out of the UNIX time stamp.

@smbyers

This comment has been minimized.

Copy link
Author

@smbyers smbyers commented Mar 23, 2020

@floturcocantsee I had been looking specifically by country and did not see a date. I guess technically the date at the /all endpoint would be the last updated for all the data (meaning data does not come in at different times per country).

@floturcocantsee

This comment has been minimized.

Copy link
Contributor

@floturcocantsee floturcocantsee commented Mar 23, 2020

There is the endpoint provided for the data from John Hopkins University: https://corona.lmao.ninja/jhucsse.
Problem is I don't know if the data provided there is actually related to what the /countries endpoint produces.

@ahmadawais

This comment has been minimized.

@ahmadawais ahmadawais closed this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.