Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up👌 Add Recovery Rate metric #13
Conversation
| /** | ||
| * Calculates the recovery rate from an array of data and splices the recovery rate | ||
| * into the middle of the array for table formatting. | ||
| * | ||
| * @param {Array} one data about the element we are processing. (e.g. state, country, etc.) | ||
| * @return {Array} A spliced array almost as it was before but now with a string formatted recovery rate. | ||
| */ | ||
| function spliceRecoveryRate(one) { |
This comment has been minimized.
This comment has been minimized.
Inukares
Mar 22, 2020
one is a poor name, as a reader I have no idea what that means.
Perhaps area would be better?
This comment has been minimized.
This comment has been minimized.
musicaljoeker
Mar 22, 2020
Author
one is the naming convention already in use in this project elsewhere for a single entry.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks a lot @musicaljoeker for sending in a PR. Good stuff. And thank you @Inukares for reviewing it. I'll check it out tomorrow. We'll soon have this here. |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR. Can you please update the PR in light of the latest release.
|
This comment has been minimized.
This comment has been minimized.
|
Hi @ahmadawais, Sorry for the later response - I was finishing up my grad midterm project this week. I'll be happy to do that. I'll see if I can get to it tonight, but if not, I'll do it tomorrow. |
musicaljoeker commentedMar 22, 2020
This PR resolves the request in #4. I changed the wording from mortality rate to recovery rate out of my own personal preference.
I'm not a JS developer by trade, so please let me know if you have any feedback. This looks like a cool project.